Kev ma/appeals 56226 #23343
Merged
Kev ma/appeals 56226 #23343
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* update restrictions to add task * update check_inbound_ops_team_user method * update specs * update specs
cacevesva
reviewed
Oct 25, 2024
| @@ -193,5 +193,21 @@ def inbound_ops_team_admin_setup | |||
| User.authenticate!(user: current_user) | |||
| end | |||
|
|
|||
| def retry_if_not_found(max_attempts: 3, cleanup: nil) | |||
cacevesva
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://jira.devops.va.gov/browse/APPEALS-56226
Description
Validated Motion to Advance On Docket task for inactive appeals is in dropdown during correspondence intake process and is generated in the backend task table and associated to the correspondence through correspondence_appeals table.
Added feature tests to submit_intake_form_spec.rb under the correspondence folder. Feature test iterates through all inactive appeals tasks, creates them through the frontend, and then performs checks to ensure that the task is created and assigned to the proper orgnanizations, and does not affect the inactive appeal's status
Acceptance Criteria
Testing Plan
Backend
Best practices
Code Documentation Updates
Tests
Test Coverage
Did you include any test coverage for your code? Check below:
Code Climate
Your code does not add any new code climate offenses? If so why?